Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve exception message for unsupported Snowflake data types #4779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nanohanno
Copy link
Contributor

What this PR does / why we need it:

For Snowflake data sources, there it is checked if all columns in a table have data types that are supported. If not an exception is thrown with limited information.

These changes add more information about which column and datatype are affected. This information will help in fixing the underlying table schema.

Which issue(s) this PR fixes:

Misc

@nanohanno nanohanno requested a review from a team as a code owner November 21, 2024 12:43
@nanohanno nanohanno changed the title Improve exception message for unsupported Snowflake data types feat: Improve exception message for unsupported Snowflake data types Nov 21, 2024
Copy link
Collaborator

@shuchu shuchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nanohanno
Copy link
Contributor Author

Who could unblock the pending checks? Seems like the build-docker-image-java task was skipped but has not reported back here? @shuchu are you able to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants