Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Printing more verbose logs when we start the offline server #4660

Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat: Printing more verbose logs when we start the offline server #4660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions sdk/python/feast/offline_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import ast
import json
import logging
import os
import sys
import traceback
from datetime import datetime
from typing import Any, Dict, List, cast

import click
import pyarrow as pa
import pyarrow.flight as fl
from google.protobuf.json_format import Parse
Expand Down Expand Up @@ -503,6 +506,24 @@ def get_table_column_names_and_types_from_data_source(self, command: dict):
)
return pa.table({"name": column_names, "type": types})

def serve(self):
message = "offline server starting with pid: "
logger.info(
message + "[%d]",
os.getpid(),
extra={"color_message": message + "[" + click.style("%d", fg="cyan") + "]"},
)
super().serve()

def shutdown(self):
message = "Sending a shutdown signal to the offline server running with pid:: "
logger.info(
message + "[%d]",
os.getpid(),
extra={"color_message": message + "[" + click.style("%d", fg="cyan") + "]"},
)
super().shutdown()


def remove_dummies(fv: FeatureView) -> FeatureView:
"""
Expand Down Expand Up @@ -533,5 +554,12 @@ def start_server(

location = "grpc+tcp://{}:{}".format(host, port)
server = OfflineServer(store, location)
logger.info(f"Offline store server serving on {location}")
server.serve()
try:
logger.info(f"Offline store server serving at: {location}")
server.serve()
except KeyboardInterrupt:
logger.info("KeyboardInterrupt received, stopping the offline server.")
finally:
server.shutdown()
logger.info("offline server stopped.")
sys.exit(0)
Loading