Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix python unit tests #3734

Merged
merged 2 commits into from
Aug 16, 2023
+1 −1
Merged

fix: Fix python unit tests #3734

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc538ad
Fix regex log_string_to_wait_for to be more generic for changing vers…
crispin-ki Aug 15, 2023
a3d067f
Add noqa otherwise flake incorrectly flags W605
crispin-ki Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix regex log_string_to_wait_for to be more generic for changing vers… 
…ions of mysql

Signed-off-by: Crispin Logan <[email protected]>
@crispin-ki
crispin-ki committed Aug 15, 2023

Verified

This commit was signed with the committer’s verified signature. The key has expired.
charlyx Charles-Henri GUERIN
GPG key ID: EF1FE839CED03386
Expired
Verified
Learn about vigilant mode
commit fc538ad113048fff4305d066d3877cb98563db67
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/test_sql_registry.py
View file
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@ def mysql_registry():
container.start()

# The log string uses '8.0.*' since the version might be changed as new Docker images are pushed.
log_string_to_wait_for = "/usr/sbin/mysqld: ready for connections. Version: '8.0.*' socket: '/var/run/mysqld/mysqld.sock' port: 3306"
log_string_to_wait_for = "/usr/sbin/mysqld: ready for connections. Version: '(\d+(\.\d+){1,2})' socket: '/var/run/mysqld/mysqld.sock' port: 3306"
waited = wait_for_logs(
container=container,
predicate=log_string_to_wait_for,