chore: Add tests to bool test type #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gbmarc1 <[email protected]>
Signed-off-by: gbmarc1 <[email protected]>
gbmarc1
changed the title
|
/assign @whoahbot |
|
Hi @gbmarc1. I see that the CI bot suggested me, but I think you may want to assign someone else to review this PR. I am only a contributor to the Bytewax materialization parts of Feast. I'm not sure why it suggested that I should be assigned. Cheers! |
|
/assign @felixwang9817 |
gbmarc1
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, gbmarc1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
_python_value_to_proto_valuefor bool values.@adchia Make sure that it indeed make sense to add the int support! Not sure about this one.