Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Try fixing lint errors #1960

Closed
wants to merge 8 commits into from
Closed

[Draft] Try fixing lint errors #1960

wants to merge 8 commits into from

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Oct 21, 2021

What this PR does / why we need it:
The latest version of pip has issues with editable pip install (pypa/pip#10573).

This temporarily removes that so CI can pass

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

…ditable pip install in latest version of pip

Signed-off-by: Danny Chiao <[email protected]>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia adchia changed the title Temporarily remove -e in pip to allow CI to pass Temporarily remove -e in install-python-ci-dependencies to allow CI to pass Oct 21, 2021
@adchia adchia removed request for a team, achals, tsotnet, woop and felixwang9817 October 21, 2021 15:15
@adchia adchia closed this Oct 21, 2021
@adchia adchia deleted the fixCI branch October 21, 2021 15:17
@adchia adchia changed the title Temporarily remove -e in install-python-ci-dependencies to allow CI to pass [Draft] Temporarily remove -e in install-python-ci-dependencies to allow CI to pass Oct 22, 2021
@adchia adchia restored the fixCI branch October 22, 2021 13:27
@adchia adchia reopened this Oct 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #1960 (fbc801c) into master (ec4c02b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1960   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          99       99           
  Lines        7922     7922           
=======================================
  Hits         6494     6494           
  Misses       1428     1428           
Flag Coverage Δ
integrationtests 73.85% <ø> (-0.44%) ⬇️
unittests 59.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4c02b...fbc801c. Read the comment docs.

@adchia adchia changed the title [Draft] Temporarily remove -e in install-python-ci-dependencies to allow CI to pass [Draft] Try fixing lint errors Oct 22, 2021
@adchia adchia closed this Oct 22, 2021
@adchia adchia deleted the fixCI branch October 22, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants