This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
state: adds offset access and manipulation #497
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds offset access and manipulation. Fixes #495.
Testing guidelines
I have a few structs that keep the table state. I use this
trait ScrollableTable
for each of these to attach actions like scroll up/down, etc. I've added thisfn recenter
to test offset manipulation.ListState
should be pretty much analogously.Note that I haven't added tests per se, because I think that these kinds of accessor/mutator functions are quite obvious.
Checklist