This repository was archived by the owner on Aug 6, 2023. It is now read-only.
Support more style modifiers on Windows and fix build with Crossterm 0.17.8 #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crossterm might actually do WinAPI calls instead of writing ANSI excape codes so writing to an intermediate String may cause issues on older versions of Windows. It also fails to compile with Crossterm 0.17.8 due to Crossterm now expecting the writer to support `flush`, which String doesn't. Fixes fdehau#373
alvinhochun
changed the title
|
Thanks for taking the time to look into this :) |
TheLostLambda
pushed a commit
to TheLostLambda/tui-rs
that referenced
this pull request
Sep 24, 2020
…and fix build with Crossterm 0.17.8 (fdehau#368) * Support more style modifiers on Windows * Change Crossterm backend to write directly to buffer instead of String Crossterm might actually do WinAPI calls instead of writing ANSI excape codes so writing to an intermediate String may cause issues on older versions of Windows. It also fails to compile with Crossterm 0.17.8 due to Crossterm now expecting the writer to support `flush`, which String doesn't. Fixes fdehau#373
24seconds
pushed a commit
to 24seconds/tui-rs
that referenced
this pull request
Nov 30, 2020
…and fix build with Crossterm 0.17.8 (fdehau#368) * Support more style modifiers on Windows * Change Crossterm backend to write directly to buffer instead of String Crossterm might actually do WinAPI calls instead of writing ANSI excape codes so writing to an intermediate String may cause issues on older versions of Windows. It also fails to compile with Crossterm 0.17.8 due to Crossterm now expecting the writer to support `flush`, which String doesn't. Fixes fdehau#373
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373.