Use an anonymous const rather than a dummy name #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running on the nightly compiler produced this warning for us:
As noted in the linter warning, the exception to the rule on this lint is an
anon-const
. This small PR updates from usingIMPL_MESSAGE_SERDE_FOR_{}
to just the anon-const_
for the const block that defines theimpl
.I've validated that this still works in our codebase and does not throw the linter warning. The impetus here is to pave the way for
this lint may become deny-by-default in the edition 2024
so when we (and other folks) transition, we don't get errors.