-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prost-wkt's build.rs shouldn't require network access #8
Comments
Good point. Maybe a better way to go about it is to use git submodules to 'link' the required |
I hit the same issue (with I tend to agree with @bpowers suggestion of simply checking in the required file into |
So you guys can move forward I think it is best if we just check in the file instead, and have the build use that instead of reaching out over the net. I stil like to have it separate from |
1 similar comment
So you guys can move forward I think it is best if we just check in the file instead, and have the build use that instead of reaching out over the net. I stil like to have it separate from |
SGTM Thanks @fdeantoni! |
containing the pbtime functions is now no longer downloaded from the Prost repo. Instead, the file is now committed under `wkt-types/resources`. The `build.rs` will use that instead.
I hopefully addressed this issue with commit a269f4d. |
Thanks @fdeantoni! I think you can drop the Any idea when this will be published to crates.io? |
I will still do a general refactoring pass over things this coming week, where I will cleanup the dependencies and clean up the code (including the code changes you recommended - PRs are welcome!). After that is done I will give it another week to verify things work correctly with the other projects that use this crate. So expect it published within the next two weeks. |
Sounds good - thanks again @fdeantoni! |
prost-wkt reaches out to download a file from github: https://github.com/fdeantoni/prost-wkt/blob/master/wkt-types/build.rs#L49
This breaks
docs.rs
builds for things that depend onprost-wkt
, like this: https://docs.rs/crate/envoy-control-plane/0.4.0/builds/502978It looks like we're pretty dependent on that specific version of the file from
prost
- can we just check it in/update it when it changes? I'm happy to put a PR up if that sounds reasonableThe text was updated successfully, but these errors were encountered: