Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotting module 레이블 오류 및 한 번에 여러 figure 창을 띄우도록 수정함(#22) #70

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Plotting module 레이블 오류 및 한 번에 여러 figure 창을 띄우도록 수정함(#22) #70

merged 1 commit into from
Aug 28, 2019

Conversation

JinraeKim
Copy link
Contributor

@JinraeKim JinraeKim commented Aug 23, 2019 •
edited
Loading

Plotting module 에서 각도 변수 관련 time series 출력 시 label 이 추가되지 않는 오류를 수정하였음
Fix the bug of plotting module when plotting time histories of angular
variables (there were no labels on figures about angular variables).

Corresponding issue: #22

Fix labeling bug of plotting module
50b3d1a 
Fix the bug of plotting module when plotting time histories of angular
variables (there were no labels on figures about angular variables).
@JinraeKim JinraeKim requested review from JungYT and seong-hun August 23, 2019 10:57
@JinraeKim JinraeKim self-assigned this Aug 23, 2019
@JinraeKim JinraeKim added the bug Something isn't working label Aug 23, 2019
@JinraeKim JinraeKim changed the title Fix labeling bug of plotting module (#22) plotting module 레이블 오류 수정 (#22) Aug 23, 2019
@JinraeKim JinraeKim changed the title plotting module 레이블 오류 수정 (#22) Plotting module 레이블 오류 수정 (#22) Aug 23, 2019
@seong-hun
Copy link
Owner

seong-hun commented Aug 23, 2019 •
edited
Loading

@JinraeKim plt.show 가 수정된 것으로 보이는데 현재 develop 버전은 이 수정사항이 반영 안되어 있으므로 연택이 풀리퀘를 먼저 반영후 이 풀리퀘를 반영해야 할 것으로 보입니다.

@JinraeKim
Copy link
Contributor Author

@seong-hun OK

JungYT
JungYT approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@JungYT JungYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어. 그래프 한 번에 나오도록 plt.show() 지운 것 확인했으니 zenhub에 하나 더 있는 plt모듈 이슈는 지울게

seong-hun
seong-hun approved these changes Aug 27, 2019
View reviewed changes
Copy link
Owner

@seong-hun seong-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

연택이 풀리퀘가 닫혔으니 이제 바로 풀리퀘를 머지해도 될 것 같네요.
한가지 제안 사항은 제목을 "레이블 오류 수정"에서 "레이블 오류 및 한 번에 여러 figure 창을 띄우도록 수정함" 정도로 바꾸면 어떨지..?

@JinraeKim JinraeKim changed the title Plotting module 레이블 오류 수정 (#22) Plotting module 레이블 오류 및 한 번에 여러 figure 창을 띄우도록 수정함(#22) Aug 28, 2019
@JinraeKim JinraeKim merged commit e0fb09d into develop Aug 28, 2019
@JinraeKim JinraeKim deleted the hotfix/iss22 branch September 9, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungYT JungYT JungYT approved these changes

@seong-hun seong-hun seong-hun approved these changes

Assignees

@JinraeKim JinraeKim

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint Aug 19 - Aug 23
Development

Successfully merging this pull request may close these issues.
3 participants
@JinraeKim @seong-hun @JungYT