Skip to content

Commit

Permalink
Revert "split_3x5_3 layout support (qmk#9624)"
Browse files Browse the repository at this point in the history
This reverts commit 139af54.
  • Loading branch information
fdawans authored Aug 11, 2020
1 parent 81d953f commit 0633867
Show file tree
Hide file tree
Showing 23 changed files with 59 additions and 191 deletions.
32 changes: 8 additions & 24 deletions keyboards/centromere/centromere.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,38 +28,22 @@
#define set_led_cyan red_led_off; grn_led_on; blu_led_on
#define set_led_white red_led_on; grn_led_on; blu_led_on

// For readability
#define ___ KC_NO

// This a shortcut to help you visually see your layout.
// The first section contains all of the arguments
// The second converts the arguments into a two-dimensional array
#define LAYOUT_split_3x6_3( \
#define LAYOUT( \
k0a, k00, k01, k02, k03, k04, k05, k06, k07, k08, k09, k0b, \
k1a, k10, k11, k12, k13, k14, k15, k16, k17, k18, k19, k1b,\
k2a, k20, k21, k22, k23, k24, k25, k26, k27, k28, k29, k2b,\
k32, k33, k34, k35, k36, k37 \
) \
{ \
{ k00, k01, k02, k03, k04, k05, k06, k07, k08, k09 }, \
{ k10, k11, k12, k13, k14, k15, k16, k17, k18, k19 }, \
{ k20, k21, k22, k23, k24, k25, k26, k27, k28, k29 }, \
{ ___, ___, k32, k33, k34, k35, k36, k37, ___, ___ }, \
{ ___, ___, k2a, k1a, k0a, k0b, k1b, k2b, ___, ___ } \
{ \
{ k00, k01, k02, k03, k04, k05, k06, k07, k08, k09 }, \
{ k10, k11, k12, k13, k14, k15, k16, k17, k18, k19 }, \
{ k20, k21, k22, k23, k24, k25, k26, k27, k28, k29 }, \
{ KC_NO, KC_NO, k32, k33, k34, k35, k36, k37, KC_NO, KC_NO }, \
{ KC_NO, KC_NO, k2a, k1a, k0a, k0b, k1b, k2b, KC_NO, KC_NO } \
}

#define LAYOUT_split_3x5_3( \
k00, k01, k02, k03, k04, k05, k06, k07, k08, k09, \
k10, k11, k12, k13, k14, k15, k16, k17, k18, k19,\
k20, k21, k22, k23, k24, k25, k26, k27, k28, k29,\
k32, k33, k34, k35, k36, k37 \
) \
{ \
{ k00, k01, k02, k03, k04, k05, k06, k07, k08, k09 }, \
{ k10, k11, k12, k13, k14, k15, k16, k17, k18, k19 }, \
{ k20, k21, k22, k23, k24, k25, k26, k27, k28, k29 }, \
{ ___, ___, k32, k33, k34, k35, k36, k37, ___, ___ }, \
{ ___, ___, ___, ___, ___, ___, ___, ___, ___, ___ } \
}

#define LAYOUT LAYOUT_split_3x6_3
#define LAYOUT_split_3x6_3 LAYOUT
42 changes: 1 addition & 41 deletions keyboards/centromere/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"width": 14,
"height": 4,
"layouts": {
"LAYOUT_split_3x6_3": {
"LAYOUT": {
"layout": [
{"label":"Tab", "x":0, "y":0.25},
{"label":"Q", "x":1, "y":0.25},
Expand Down Expand Up @@ -50,46 +50,6 @@
{"label":"MO(_NUM)", "x":8.5, "y":3.25},
{"label":"RAlt", "x":9.5, "y":3.125}
]
},
"LAYOUT_split_3x5_3": {
"layout": [
{"label":"Q", "x":0, "y":0.25},
{"label":"W", "x":1, "y":0.125},
{"label":"E", "x":2, "y":0},
{"label":"R", "x":3, "y":0.125},
{"label":"T", "x":4, "y":0.25},
{"label":"Y", "x":7, "y":0.25},
{"label":"U", "x":8, "y":0.125},
{"label":"I", "x":9, "y":0},
{"label":"O", "x":10, "y":0.125},
{"label":"P", "x":11, "y":0.25},
{"label":"A", "x":0, "y":1.25},
{"label":"S", "x":1, "y":1.125},
{"label":"D", "x":2, "y":1},
{"label":"F", "x":3, "y":1.125},
{"label":"G", "x":4, "y":1.25},
{"label":"H", "x":7, "y":1.25},
{"label":"J", "x":8, "y":1.125},
{"label":"K", "x":9, "y":1},
{"label":"L", "x":10, "y":1.125},
{"label":";", "x":11, "y":1.25},
{"label":"Z", "x":0, "y":2.25},
{"label":"X", "x":1, "y":2.125},
{"label":"C", "x":2, "y":2},
{"label":"V", "x":3, "y":2.125},
{"label":"B", "x":4, "y":2.25},
{"label":"N", "x":7, "y":2.25},
{"label":"M", "x":8, "y":2.125},
{"label":",", "x":9, "y":2},
{"label":".", "x":10, "y":2.125},
{"label":"/", "x":11, "y":2.25},
{"label":"LGUI", "x":2.5, "y":3.125},
{"label":"MO(_FN)", "x":3.5, "y":3.25},
{"label":"Space", "x":4.5, "y":3.375},
{"label":"Space", "x":6.5, "y":3.375},
{"label":"MO(_NUM)", "x":7.5, "y":3.25},
{"label":"RAlt", "x":8.5, "y":3.125}
]
}
}
}
6 changes: 3 additions & 3 deletions keyboards/centromere/keymaps/default/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ enum centromere_layers

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {

[_STD] = LAYOUT_split_3x6_3( \
[_STD] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_BSPC,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand All @@ -24,7 +24,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
),


[_NUM] = LAYOUT_split_3x6_3( \
[_NUM] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_BSPC,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand All @@ -36,7 +36,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
//`--------------------------' `--------------------------'
),

[_FN] = LAYOUT_split_3x6_3( \
[_FN] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
KC_ESC, KC_EXLM, KC_AT, KC_HASH, KC_DLR, KC_PERC, KC_CIRC, KC_AMPR, KC_ASTR, KC_LPRN, KC_RPRN, KC_BSPC,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand Down
6 changes: 3 additions & 3 deletions keyboards/centromere/keymaps/default_u2/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ enum centromere_layers

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {

[_STD] = LAYOUT_split_3x6_3( \
[_STD] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_BSPC,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand All @@ -23,7 +23,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
),


[_NUM] = LAYOUT_split_3x6_3( \
[_NUM] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_BSPC,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand All @@ -35,7 +35,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
//`--------------------------' `--------------------------'
),

[_FN] = LAYOUT_split_3x6_3( \
[_FN] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
KC_ESC, KC_EXLM, KC_AT, KC_HASH, KC_DLR, KC_PERC, KC_CIRC, KC_AMPR, KC_ASTR, KC_LPRN, KC_RPRN, KC_BSPC,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand Down
32 changes: 16 additions & 16 deletions keyboards/centromere/keymaps/mini/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
* | | | |
* `------' `------'
*/
[_QWERTY] = LAYOUT_split_3x5_3(
KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P,
KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN,
KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH,
[_QWERTY] = LAYOUT(
KC_NO, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_NO,
KC_NO, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_NO,
KC_NO, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_NO,
KC_LCTL, LOWER, KC_SPC, KC_BSPC, RAISE, OSM(MOD_LSFT)
),

Expand All @@ -60,10 +60,10 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
* | | | |
* `------' `------'
*/
[_RAISE] = LAYOUT_split_3x5_3(
KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0,
KC_TAB, KC_LEFT, KC_DOWN, KC_UP, KC_RGHT, _______, KC_MINS, KC_EQL, KC_LBRC, KC_RBRC,
KC_LCTL, KC_GRV, KC_LGUI, KC_LALT, _______, _______, _______, _______, KC_BSLS, KC_QUOT,
[_RAISE] = LAYOUT(
KC_NO, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_NO,
KC_NO, KC_TAB, KC_LEFT, KC_DOWN, KC_UP, KC_RGHT, _______, KC_MINS, KC_EQL, KC_LBRC, KC_RBRC, KC_NO,
KC_NO, KC_LCTL, KC_GRV, KC_LGUI, KC_LALT, _______, _______, _______, _______, KC_BSLS, KC_QUOT, KC_NO,
_______, _______, _______, _______, _______, _______
),

Expand All @@ -82,10 +82,10 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
* | | | |
* `------' `------'
*/
[_LOWER] = LAYOUT_split_3x5_3(
KC_EXLM, KC_AT, KC_HASH, KC_DLR, KC_PERC, KC_CIRC, KC_AMPR, KC_ASTR, KC_LPRN, KC_RPRN,
KC_ESC, _______, _______, _______, _______, _______, KC_UNDS, KC_PLUS, KC_LCBR, KC_RCBR,
KC_CAPS, KC_TILD, _______, _______, _______, _______, _______, _______, KC_PIPE, KC_DQT,
[_LOWER] = LAYOUT(
KC_NO, KC_EXLM, KC_AT, KC_HASH, KC_DLR, KC_PERC, KC_CIRC, KC_AMPR, KC_ASTR, KC_LPRN, KC_RPRN, KC_NO,
KC_NO, KC_ESC, _______, _______, _______, _______, _______, KC_UNDS, KC_PLUS, KC_LCBR, KC_RCBR, KC_NO,
KC_NO, KC_CAPS, KC_TILD, _______, _______, _______, _______, _______, _______, KC_PIPE, KC_DQT, KC_NO,
_______, _______, _______, KC_ENT, _______, KC_DEL
),

Expand All @@ -104,10 +104,10 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
* | | | |
* `------' `------'
*/
[_ADJUST] = LAYOUT_split_3x5_3(
KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10,
KC_F11, KC_F12, _______, _______, _______, _______, _______, _______, TSKMGR, CALTDEL,
RESET, _______, _______, _______, _______, _______, _______, _______, _______, _______,
[_ADJUST] = LAYOUT(
KC_NO, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_NO,
KC_NO, KC_F11, KC_F12, _______, _______, _______, _______, _______, _______, TSKMGR, CALTDEL, KC_NO,
KC_NO, RESET, _______, _______, _______, _______, _______, _______, _______, _______, _______, KC_NO,
_______, _______, _______, _______, _______, _______
)
};
Expand Down
2 changes: 1 addition & 1 deletion keyboards/centromere/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ OPT_DEFS += -DCENTROMERE_PROMICRO
# # project specific files
SRC = matrix.c

LAYOUTS = split_3x5_3 split_3x6_3
LAYOUTS = split_3x6_3
49 changes: 1 addition & 48 deletions keyboards/crkbd/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"width": 15,
"height": 4.7,
"layouts": {
"LAYOUT_split_3x6_3": {
"LAYOUT": {
"layout": [
{"label":"Esc", "x":0, "y":0.3},
{"label":"Q", "x":1, "y":0.3},
Expand Down Expand Up @@ -57,53 +57,6 @@
{"label":"Raise", "x":9, "y":3.7},
{"label":"Alt / KC_HAEN", "x":10, "y":3.7}
]
},
"LAYOUT_split_3x5_3": {
"layout": [
{"label":"Q", "x":0, "y":0.3},
{"label":"W", "x":1, "y":0.1},
{"label":"E", "x":2, "y":0},
{"label":"R", "x":3, "y":0.1},
{"label":"T", "x":4, "y":0.2},

{"label":"Y", "x":8, "y":0.2},
{"label":"U", "x":9, "y":0.1},
{"label":"I", "x":10, "y":0},
{"label":"O", "x":11, "y":0.1},
{"label":"P", "x":12, "y":0.3},

{"label":"A", "x":0, "y":1.3},
{"label":"S", "x":1, "y":1.1},
{"label":"D", "x":2, "y":1},
{"label":"F", "x":3, "y":1.1},
{"label":"G", "x":4, "y":1.2},

{"label":"H", "x":8, "y":1.2},
{"label":"J", "x":9, "y":1.1},
{"label":"K", "x":10, "y":1},
{"label":"L", "x":11, "y":1.1},
{"label":";", "x":12, "y":1.3},

{"label":"Z", "x":0, "y":2.3},
{"label":"X", "x":1, "y":2.1},
{"label":"C", "x":2, "y":2},
{"label":"V", "x":3, "y":2.1},
{"label":"B", "x":4, "y":2.2},

{"label":"N", "x":8, "y":2.2},
{"label":"M", "x":9, "y":2.1},
{"label":",", "x":10, "y":2},
{"label":".", "x":11, "y":2.1},
{"label":"/", "x":12, "y":2.3},

{"label":"GUI / KC_HANJ", "x":3, "y":3.7},
{"label":"Lower", "x":4, "y":3.7},
{"label":"Space", "x":5, "y":3.2, "h":1.5},

{"label":"Enter", "x":7, "y":3.2, "h":1.5},
{"label":"Raise", "x":8, "y":3.7},
{"label":"Alt / KC_HAEN", "x":9, "y":3.7}
]
}
}
}
8 changes: 4 additions & 4 deletions keyboards/crkbd/keymaps/default/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ enum macro_keycodes {
};

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
[_QWERTY] = LAYOUT_split_3x6_3( \
[_QWERTY] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_BSPC,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand All @@ -44,7 +44,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {

),

[_LOWER] = LAYOUT_split_3x6_3( \
[_LOWER] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_BSPC,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand All @@ -56,7 +56,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
//`--------------------------' `--------------------------'
),

[_RAISE] = LAYOUT_split_3x6_3( \
[_RAISE] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
KC_ESC, KC_EXLM, KC_AT, KC_HASH, KC_DLR, KC_PERC, KC_CIRC, KC_AMPR, KC_ASTR, KC_LPRN, KC_RPRN, KC_BSPC,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand All @@ -68,7 +68,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
//`--------------------------' `--------------------------'
),

[_ADJUST] = LAYOUT_split_3x6_3( \
[_ADJUST] = LAYOUT( \
//,-----------------------------------------------------. ,-----------------------------------------------------.
RESET, RGBRST, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX,\
//|--------+--------+--------+--------+--------+--------| |--------+--------+--------+--------+--------+--------|
Expand Down
21 changes: 2 additions & 19 deletions keyboards/crkbd/rev1/rev1.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#endif

// clang-format off
#define LAYOUT_split_3x6_3( \
#define LAYOUT( \
L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, \
L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, \
L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, \
Expand All @@ -39,23 +39,6 @@
{ KC_NO, KC_NO, KC_NO, R32, R31, R30 } \
}

#define LAYOUT_split_3x5_3( \
L00, L01, L02, L03, L04, R00, R01, R02, R03, R04, \
L10, L11, L12, L13, L14, R10, R11, R12, R13, R14, \
L20, L21, L22, L23, L24, R20, R21, R22, R23, R24, \
L30, L31, L32, R30, R31, R32 \
) \
{ \
{ KC_NO, L00, L01, L02, L03, L04 }, \
{ KC_NO, L10, L11, L12, L13, L14 }, \
{ KC_NO, L20, L21, L22, L23, L24 }, \
{ KC_NO, KC_NO, KC_NO, L30, L31, L32 }, \
{ KC_NO, R04, R03, R02, R01, R00 }, \
{ KC_NO, R14, R13, R12, R11, R10 }, \
{ KC_NO, R24, R23, R22, R21, R20 }, \
{ KC_NO, KC_NO, KC_NO, R32, R31, R30 } \
}

#define LAYOUT_kc( \
L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, \
L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, \
Expand All @@ -70,4 +53,4 @@
)
// clang-format on

#define LAYOUT LAYOUT_split_3x6_3
#define LAYOUT_split_3x6_3 LAYOUT
2 changes: 1 addition & 1 deletion keyboards/crkbd/rev1/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ SRC += matrix.c \
split_util.c \
split_scomm.c

LAYOUTS = split_3x5_3 split_3x6_3
LAYOUTS = split_3x6_3
2 changes: 1 addition & 1 deletion keyboards/miniaxe/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"width": 11,
"height": 4,
"layouts": {
"LAYOUT_split_3x5_3": {
"LAYOUT": {
"layout": [{"label":"Q", "x":0, "y":0}, {"label":"W", "x":1, "y":0}, {"label":"E", "x":2, "y":0}, {"label":"R", "x":3, "y":0}, {"label":"T", "x":4, "y":0}, {"label":"Y", "x":6, "y":0}, {"label":"U", "x":7, "y":0}, {"label":"I", "x":8, "y":0}, {"label":"O", "x":9, "y":0}, {"label":"P", "x":10, "y":0}, {"label":"A", "x":0, "y":1}, {"label":"S", "x":1, "y":1}, {"label":"D", "x":2, "y":1}, {"label":"F", "x":3, "y":1}, {"label":"G", "x":4, "y":1}, {"label":"J", "x":6, "y":1}, {"label":"J", "x":7, "y":1}, {"label":"K", "x":8, "y":1}, {"label":"L", "x":9, "y":1}, {"label":";", "x":10, "y":1}, {"label":"Z", "x":0, "y":2}, {"label":"X", "x":1, "y":2}, {"label":"C", "x":2, "y":2}, {"label":"V", "x":3, "y":2}, {"label":"B", "x":4, "y":2}, {"label":"N", "x":6, "y":2}, {"label":"M", "x":7, "y":2}, {"label":",", "x":8, "y":2}, {"label":".", "x":9, "y":2}, {"label":"/", "x":10, "y":2}, {"label":"Cmd", "x":2, "y":3}, {"label":"⇓", "x":3, "y":3}, {"label":"Ctrl", "x":4, "y":3}, {"x":6, "y":3}, {"label":"⇑", "x":7, "y":3}, {"label":"Opt", "x":8, "y":3}]
}
}
Expand Down
Loading

0 comments on commit 0633867

Please sign in to comment.