-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regularly rebuild image of latest release #17
Regularly rebuild image of latest release #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and targets same JDK versions as fcrepo/fcrepo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small questions/comments, but overall the changes look good.
Thanks @andyundso and sorry for the long delay.
I agree, that the pipeline could be greatly simpilified. When the Docker image for Fedora 6 was created initially, some in the Fedora community had reservations against integrating the Docker image into the main fcrepo repository. We can check if that's still the case, once this PR has been merged. When sticking with the 2-repository solution, I think the way forward is:
|
|
||
./build-and-push-to-dockerhub.sh ../fcrepo-webapp/target/fcrepo-webapp-$LATEST_RELEASE_VERSION.war "${a[0]}.${a[1]}.${a[2]}-tomcat9" "${a[0]}.${a[1]}-tomcat9" "${a[0]}-tomcat9" | ||
./build-and-push-to-dockerhub.sh ../fcrepo-webapp/target/fcrepo-webapp-$LATEST_RELEASE_VERSION.war "${a[0]}.${a[1]}.${a[2]}-tomcat9" "${VERSION_PARTS[0]}.${VERSION_PARTS[1]}-tomcat9" "${VERSION_PARTS[0]}-tomcat9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old variable name a
is still to construct the tag with the full version number.
Should be:
"${VERSION_PARTS[0]}.${VERSION_PARTS[1].${VERSION_PARTS[2]}-tomcat9"
ed19d18
to
cdf9edc
Compare
PR looks good now. I also tested the commands locally and was able to correctly build the Docker image. |
@Surfrdan Can you merge this? I'm a bit unsure what procedure there is to merge PRs in this repo. |
Fixes FCREPO-3849 and FCREPO-3850.
This PR adds a new GitHub Actions workflow. In a nutshell:
fcrepo/fcrepo
, excluding tags that includeRC
. For the found tag, we can safely assume it's the latest release offcrepo
.fcrepo
.The pipeline is triggered:
workflow_dispatch
.main
.A successful run looks something like this.
Note that this pipeline could be simplified:
fcrepo
, so we don't have to checkout two repository to make this pipeline work.maven build
, so this pipeline's instructions can be simplified.