Make any and all short-circuiting

fix JuliaLang#11750

base/reduce.jl

@@ -298,45 +298,34 @@ end
 
 ## all & any
 
-function mapfoldl(f, ::AndFun, itr)
+function any(f, itr)
     for x in itr
-        !f(x) && return false
+        f(x) && return true
     end
-    return true
+    return false
 end
 
-function mapfoldl(f, ::OrFun, itr)
+function any(itr)
     for x in itr
-        f(x) && return true
+        x && return true
     end
     return false
 end
 
-function mapreduce_impl(f, op::AndFun, A::AbstractArray{Bool}, ifirst::Int, ilast::Int)
-    while ifirst <= ilast
-        @inbounds x = A[ifirst]
+function all(f, itr)
+    for x in itr
         !f(x) && return false
-        ifirst += 1
     end
     return true
 end
 
-function mapreduce_impl(f, op::OrFun, A::AbstractArray{Bool}, ifirst::Int, ilast::Int)
-    while ifirst <= ilast
-        @inbounds x = A[ifirst]
-        f(x) && return true
-        ifirst += 1
+function all(itr)
+    for x in itr
+        !x && return false
     end
-    return false
+    return true
 end
 
-all(a) = mapreduce(IdFun(), AndFun(), a)
-any(a) = mapreduce(IdFun(), OrFun(), a)
-
-all(pred::Union{Callable,Func{1}}, a) = mapreduce(pred, AndFun(), a)
-any(pred::Union{Callable,Func{1}}, a) = mapreduce(pred, OrFun(), a)
-
-
 ## in & contains
 
 immutable EqX{T} <: Func{1}

test/reduce.jl

@@ -201,6 +201,16 @@ prod2(itr) = invoke(prod, Tuple{Any}, itr)
 @test reduce(&, fill(trues(5), 24))  == trues(5)
 @test reduce(&, fill(falses(5), 24)) == falses(5)
 
+# short-circuiting any and all
+
+let c1 = 0, c2 = 0, A1 = collect(1:1000), A2 = collect(1:1000)
+    any(x->(c1+=1; x==10), A1)
+    all(x->(c2+=1; x!=10), A2)
+
+    @test c1 == 10
+    @test c2 == 10
+end
+
 # in
 
 @test in(1, Int[]) == false