Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Client variables #419

Merged
merged 8 commits into from
Apr 25, 2019
Merged

Clean up Client variables #419

merged 8 commits into from
Apr 25, 2019

Commits on Apr 17, 2019

  1. Remove redundant client variables

    @madsmtm
    madsmtm committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    a159999 View commit details
    Browse the repository at this point in the history

  2. Remove temporary _postLogin variables from the client

    @madsmtm
    madsmtm committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    6ab298f View commit details
    Browse the repository at this point in the history

  3. Remove email/password client variables

    @madsmtm
    madsmtm committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    a079797 View commit details
    Browse the repository at this point in the history

  4. Privatize fb_h and client_id variables 

    These are sparsely used and badly named, so probably not externally depended on externally
    @madsmtm
    madsmtm committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    9b81365 View commit details
    Browse the repository at this point in the history

  5. Privatize default_thread_X client variables 

    We have a setter method for them, so there should be no need to access these directly!
    @madsmtm
    madsmtm committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    2f973f1 View commit details
    Browse the repository at this point in the history

  6. Make Client.uid read-only 

    Modifying `uid` was previously documented as giving undefined behaviour, now it'll throw an error
    @madsmtm
    madsmtm committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    c688d64 View commit details
    Browse the repository at this point in the history

  7. Privatize sticky and pool client variables 

    These have complicated semantics, and so are hopefully not depended on externally
    @madsmtm
    madsmtm committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    0fd86d0 View commit details
    Browse the repository at this point in the history

  8. Privatize req_counter, payloadDefault and seq client variables 

    These have complicated semantics, and so are hopefully not depended on externally
    @madsmtm
    madsmtm committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    bfca20b View commit details
    Browse the repository at this point in the history