FE-6299 Implement FQL formatting for v4 queries #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecooper
approved these changes
Jan 13, 2025
henryfauna
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are defaulting all queries to JSON, which prints the wire protocol. v10 queries print the FQL format by default.
Other work while here
Some valid FQL expressions are recognized as executable javascript, including objects and any falsy values like
nullandfalse, so they are either treated strangely or rejected as queries.Solution
Output FQL formatting for v4 queries using
util.inspect().Colorize the output using the FQL grammar.
wrap query expressions in an IIFE so that simple values can be provided as queries.
Result
Testing
Added tests to verify formatting and ability to query simple values.