Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fauna schema commit and abandon #357

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

macmv
Copy link
Contributor

@macmv macmv commented Sep 11, 2024

Ticket(s): ENG-6323

Adds fauna schema commit and fauna schema abandon.

These are very similar, except for some wording in the resulting messages, and commit will only run if the schema status is ready.

@macmv macmv requested review from freels and wdberkeley September 11, 2024 21:58
Copy link
Member

@freels freels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo some minor copy comments

@macmv macmv force-pushed the add-schema-commit-abandon branch 2 times, most recently from c58ca12 to 80bc57d Compare September 11, 2024 23:15
@macmv macmv force-pushed the add-schema-status branch 2 times, most recently from 2b3f808 to 53b6d95 Compare September 11, 2024 23:31
@macmv macmv force-pushed the add-schema-commit-abandon branch from 80bc57d to f5014ae Compare September 11, 2024 23:31
@macmv macmv force-pushed the add-schema-commit-abandon branch from c7a392d to cdc33b8 Compare September 12, 2024 21:23
@macmv macmv force-pushed the add-schema-commit-abandon branch from 17810b8 to 19a27c2 Compare September 16, 2024 16:38
@macmv macmv force-pushed the add-schema-commit-abandon branch 2 times, most recently from 79f4e51 to 636f218 Compare September 17, 2024 00:42
Base automatically changed from add-schema-status to main September 17, 2024 21:34

Verified

This commit was signed with the committer’s verified signature.
macmv Neil Macneale V
@macmv macmv force-pushed the add-schema-commit-abandon branch from 636f218 to 18eaf32 Compare September 17, 2024 21:34
@macmv macmv merged commit 9e4afd6 into main Sep 17, 2024
1 check was pending
@macmv macmv deleted the add-schema-commit-abandon branch September 17, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants