Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fauna schema status #356

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Add fauna schema status #356

merged 1 commit into from
Sep 17, 2024

Conversation

macmv
Copy link
Contributor

@macmv macmv commented Sep 10, 2024

Ticket(s): ENG-6711

Adds fauna schema status, which shows the current staged status for a database.

This accepts a --dir option, so that it'll integrate with the other project management stuff.

@macmv macmv force-pushed the add-schema-push-staged branch from b3044e6 to efae39e Compare September 10, 2024 22:59
@macmv macmv force-pushed the add-schema-status branch 2 times, most recently from 0a03f31 to d0dc7b1 Compare September 10, 2024 23:39
Copy link
Member

@freels freels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 93 to 95
|
|
|`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are some interesting newlines...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed. I think two are from core, and one is from the shell.

@macmv macmv force-pushed the add-schema-push-staged branch from 7cbb537 to 4ae4766 Compare September 11, 2024 23:10
@macmv macmv force-pushed the add-schema-push-staged branch 4 times, most recently from 7758c38 to a4267b8 Compare September 11, 2024 23:28
@macmv macmv force-pushed the add-schema-push-staged branch from a4267b8 to 5667739 Compare September 16, 2024 16:38
@macmv macmv force-pushed the add-schema-push-staged branch 2 times, most recently from 6126450 to d66c2ca Compare September 16, 2024 23:36
@macmv macmv force-pushed the add-schema-push-staged branch from d66c2ca to 4afab33 Compare September 17, 2024 21:33
Base automatically changed from add-schema-push-staged to main September 17, 2024 21:33
@macmv macmv merged commit 534e88f into main Sep 17, 2024
1 check was pending
@macmv macmv deleted the add-schema-status branch September 17, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants