v4 temporary header #346
Merged
v4 temporary header #346
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echo-bravo-yahoo
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-5644
Problem
New users will eventually be unable to use the basic shell commands as they will not have v4 access
Solution
Until all shell functions can be rewritten to use the v10 Fauna api, employ a temporary header that Core can use to continue to allow these v4 calls from the shell.
shellrepl sessions andevalv4 commands will, however, not receive the temporary header and will work based on the user's access policy.Result
Unblock launch of v4 access restriction until we have bandwidth to rewrite shell functions to v10.
Risk being that the header is publicly available and could be leveraged by any user regardless of their v4 access policy.
Testing
Updated some tests to expect the header on commands other than
eval.TODO:
shelltests have been turned off for a while