Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for v10 release #224

Merged
merged 8 commits into from
Aug 16, 2023
Merged

Updates for v10 release #224

merged 8 commits into from
Aug 16, 2023

Conversation

macmv
Copy link
Contributor

@macmv macmv commented Aug 15, 2023

Updates things to release the shell for v10. Changes include:

  • Change default eval format to use isatty in all versions
  • Default to v10 for fauna shell and fauna eval
  • Update description and examples of eval/shell
  • Update README for v10

@macmv macmv requested review from freels and wdberkeley August 15, 2023 16:28
breinero
breinero suggested changes Aug 15, 2023
View reviewed changes
Copy link

@breinero breinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor grammatical nit, but otherwise LGTM

README.md Outdated Show resolved Hide resolved
freels
freels approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@freels freels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@breinero feels like the mini-tutorial could be moved/replaced with docs. At the very least it deserves a refresh to showcase v10 features.

freels
freels requested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@freels freels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there are quite a few more FaunaDB references that need to be fixed.

freels
freels reviewed Aug 16, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@macmv macmv requested a review from freels August 16, 2023 22:48
freels
freels approved these changes Aug 16, 2023
View reviewed changes
docs/dev.md Outdated Show resolved Hide resolved
@macmv macmv merged commit 4c73ec2 into main Aug 16, 2023
@macmv macmv deleted the updates-for-release branch August 16, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breinero breinero breinero requested changes

@freels freels freels approved these changes

@wdberkeley wdberkeley Awaiting requested review from wdberkeley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macmv @freels @breinero