Fix two bugs in simple switch 13 examples #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
grantcurell
commented
Apr 1, 2020
grantcurell
commented
- dpid with leading 0s would be truncated to less than 16 characters. This causes 404 errors on all URLs because the code would save the 15 character ID for the switch, but if you try to enter the 15 character ID, the dpid_lib DPID_PATTERN regex prevents you from sending the shortened string.
- Response object incorrectly used body type when it should use text. See: Default charset does not apply to JSON responses Pylons/webob#298
- dpid with leading 0s would be truncated to less than 16 characters - Response object incorrectly used body type when it should use text
1 similar comment
|
pushed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.