Don't fire draggable:end if draggable:start has not been fired #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draggable:start
is fired when the first mousemove happens after mousedown. Currently,draggable:end
is fired on mouseup, regardless if there has been a mousemove. Thus, when clicking a draggable element (without moving the mouse between mousedown and mouseup),draggable:end
is fired withoutdraggable:start
having been fired.This has the effect that
ng-drag-success
is executed on the draggable element as if it had been successfully dropped somewhere, but in fact no droppable element will executeng-drop-success
, as droppable elements only start checking whether anythingisTouching
them after adraggable:start
event.In my case I am moving an element, so one is removed on
ng-drag-success
and another one is created onng-drop-success
. When clicking the element, it is removed.