Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not redefine functions #2189

Merged
merged 1 commit into from
Mar 24, 2019
Merged

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Mar 24, 2019

Move all script scoped function definitions within a function out of
those functions, because defining them within a function causes them to
be redefined each time the function is executed. When the previous
definition is still in use, errors can result.

Fixes #2162

Move all script scoped function definitions within a function out of
those functions, because defining them within a function causes them to
be redefined each time the function is executed. When the previous
definition is still in use, errors can result.

Fixes fatih#2162
@bhcleek bhcleek merged commit 96bd5e4 into fatih:master Mar 24, 2019
@bhcleek bhcleek deleted the avoid-function-redefinition branch March 24, 2019 01:38
bhcleek added a commit that referenced this pull request Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant