windows: enable virtual terminal processing, fixes #169 #186
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||||||||||||||||
| package color | ||||||||||||||||||||
|
|
||||||||||||||||||||
| import ( | ||||||||||||||||||||
| "os" | ||||||||||||||||||||
|
|
||||||||||||||||||||
| "golang.org/x/sys/windows" | ||||||||||||||||||||
| ) | ||||||||||||||||||||
|
|
||||||||||||||||||||
| func init() { | ||||||||||||||||||||
| // Opt-in for ansi color support for current process. | ||||||||||||||||||||
| // https://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences#output-sequences | ||||||||||||||||||||
| var outMode uint32 | ||||||||||||||||||||
| out := windows.Handle(os.Stdout.Fd()) | ||||||||||||||||||||
| if err := windows.GetConsoleMode(out, &outMode); err == nil { | ||||||||||||||||||||
| outMode |= windows.ENABLE_PROCESSED_OUTPUT | windows.ENABLE_VIRTUAL_TERMINAL_PROCESSING | ||||||||||||||||||||
| _ = windows.SetConsoleMode(out, outMode) | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
Comment on lines
+14
to
+17
There was a problem hiding this comment. Indent Error Flow
Suggested change
reference: https://github.com/golang/go/wiki/CodeReviewComments#indent-error-flow |
||||||||||||||||||||
| } | ||||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,4 @@ require ( | |
| github.com/mattn/go-isatty v0.0.17 | ||
| ) | ||
|
|
||
| require golang.org/x/sys v0.5.0 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
NO_COLORenv var andNoColor = trueglobal variable to opt-out?In such configuration this code should not be executed.
#173 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
NO_COLORenv already changes theNoColorvalue. So we can just check for theNoColorvariable and it'll cover everything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I guess it is just a matter of adding
right? 😉
@fatih let me know if you want me to address my own comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem though is, it wouldn't work as expected. Imagine this situation:
NO_COLOR.init()is called, it check'sNoColor, if it's false it will not set the configurationNoColor = false.init()will not run anymore. So we need a separate enviornment variable.NoColoris working fine as it's now, but it wouldn't work for opt-out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding #2. init() is run after all var () blocks, so NoColor would be set before init() is called.