Fix equivalent sources tests failing after sklearn 1.6.0 #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test cartesian equivalent sources with f32 and f64 dtypes and also with `damping` as `None` and with a very small value. Mark the combination of `damping=None` and `dtype=np.float32` with `xfail`, so it gets flagged but `pytest` doesn't errors out. Since the equivalent sources with damping are more accurate, we don't need to have different absolute tolerances for both cases: keep a single value for `atol`. Set some very low absolute tolerances in spherical equivalent sources tests.
santisoler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cartesian equivalent sources with f32 and f64 dtypes and also with
dampingasNoneand with a very small value. Mark the combination ofdamping=Noneanddtype=np.float32withxfail, so it gets flagged butpytestdoesn't error out. Since the equivalent sources with damping are more accurate, we don't need to have different absolute tolerances for both cases: keep a single value foratol. Set some very low absolute tolerances in spherical equivalent sources tests and in gradient-boosted equivalent sources tests.Relevant issues/PRs:
Fixes #546