Ditch setup.cfg and use only pyproject.toml #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `setup.cfg`. Move all project metadata and build instructions to `pyproject.toml`. Move flake8 configuration to .flake8. Use `harmonica/_version.py` to store the generated version by `setuptools-scm`, and append the leading `v` to the version number directly in `harmonica/__init__.py`.
2 tasks
Closed
leouieda
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Looks great! Would be nice to get rid of .flake8 at some point but 🤷🏾
The reason we had a _version_generated and a _version file was because of Pooch. When data were hosted here, we needed to import the __version__ string and it caused a circular import if we fetched it from the base __init__.py. Now that we use Ensaio, we don't need it anymore.
santisoler
added a commit
that referenced
this pull request
Mar 22, 2024
Extend the list of classifiers, mostly restore the ones that were lost during the move from `setup.cfg` to `pyproject.toml`. Restoring classifiers that were lost in #438.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
setup.cfg. Move all project metadata and build instructions topyproject.toml. Moveflake8configuration to.flake8. Useharmonica/_version.pyto store the generated version bysetuptools-scm, and append the leadingvto the version number directly inharmonica/__init__.py. Pin newer version ofsetuptoolsandsetuptools_scm. Make use ofdependente==0.3.0that adds support to packages that usepyproject.tomlonly.