Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test skip since problem fixed in qonnx #1152

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmitrevs
Copy link
Contributor

Description

There currently is one test that is skipped because the qonnx channels-last conversion fails with it. Wit the current head of qonnx, this is no longer the case, so we no longer need to skip the test. However, we need to update our test environment first, so this is created as a draft at the moment

Type of change

[x] Other (Specify) Stop skipping a test

Tests

The pytests should all pass after we create a new testing container.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs changed the title remove the skip since problem fixed in qonnx remove test skip since problem fixed in qonnx Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant