Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi output fix 2 #1101

Closed
wants to merge 0 commits into from

Conversation

calad0i
Copy link
Contributor

@calad0i calad0i commented Oct 29, 2024

Description

Fixes the following:

  • Fix output node updating mechanism. The current parser assumes set(outputs)-set(inputs) are the output nodes, which is not true if some intermediate nodes are being outputted, or if any inputs are unused.
  • remove_node is updated to correctly rewire in all cases, including leaf/intermediate+leaf nodes. Deprecate arg rewire
  • Drop and rewire flatten layers instead of making variable name alias to avoid errors when the tensor is outputted.
  • Update flatten layer's output shape in io_stream to correctly handle the case where

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

test/pytest/test_multiout_network.py/test_multi_output_nn_2

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@calad0i calad0i closed this Oct 29, 2024
@calad0i calad0i force-pushed the multi_output_fix_2 branch from 42766b5 to 25b08cf Compare October 29, 2024 16:34
@calad0i calad0i mentioned this pull request Nov 8, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant