-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GarNet examples + config-files and data directories #4
Conversation
Or perhaps right before it is merged, because I'm adding a test line that uses the 1layer model. |
Hm ... this actually might complicate things a little bit. Because of a few things:
|
Actually, regarding point 2, I don't think there would be any problem now that I looked into the test. So you just have to move the tag 😁. Also, maybe we can merge this PR first, and then I'll make some changes to the fetching examples scheme (should be quick) to your PR 213, then we can merge it to |
Thanks for the comments @Duchstf ! I think it's better to merge this PR first before 213 (despite my original comment in this PR - which I edited now). |
KerasJson: garnet_3layer.json | ||
KerasH5: garnet_3layer_weights.h5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything looks good now. I just have a question here. If you do end up using the config file in your test, wouldn't you use relative path here? Or is it not important?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are fine leaving them like this I can merge this PR now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think it's fine like this. These lines are sort of suggesting that the user should copy all relevant files into a work directory before running hls4ml convert
.
To be merged after hls4ml PR 213 is merged.Although the examples would not convert / build without hls4ml PR 213, let's merge this PR first because 213 uses one of the new examples for build tests.