HTTP Cache API #1051
Open
HTTP Cache API #1051
+4,156
−242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
http-cache
branch
2 times, most recently
from
3f13d65 to
f78e621
Compare
guybedford
changed the title
guybedford
force-pushed
the
http-cache
branch
from
f78e621 to
aa85eaf
Compare
guybedford
force-pushed
the
http-cache
branch
4 times, most recently
from
d663577 to
d691bf5
Compare
guybedford
force-pushed
the
http-cache
branch
from
d691bf5 to
ab7846e
Compare
guybedford
force-pushed
the
http-cache
branch
4 times, most recently
from
1df917e to
39159e7
Compare
guybedford
force-pushed
the
http-cache
branch
from
e993c64 to
ed4e25f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing uses a variation of #1018 that uses real mutable Request and Response objects instead of relying on a new CandidateResponse object. A new error is then thrown when attempting to access the body of one of these response objects to support the CandidateResponse semantics. Effectively the CacheHandle slot being set handles the divergence here.
In the process, we also update
new CacheControl('override', { ... opts ... })to have the new direct override object syntax variationnew CacheControl({ ...opts... })as the override.The
fetchimplementation is upgraded to usesend_async_v2and the new implementation is very closely based to the Rust implementation which should replicate the former caching logic in its entirety making this a backwards compatible change.Support for the
fetchcacheoption is not implemented here although could now be partially implemented as per #1050, which is effectively unblocked by this landing.