Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loggly endpoint support #169

Merged
merged 4 commits into from
May 11, 2020
Merged

Add Loggly endpoint support #169

merged 4 commits into from
May 11, 2020

Conversation

ezkl
Copy link
Contributor

@ezkl ezkl commented May 6, 2020

See the docs for more information on Loggly logging endpoints.

@ezkl ezkl force-pushed the ezkl/add-loggly branch from fea07cf to 56e2d41 Compare May 8, 2020 11:37
@ezkl ezkl requested a review from phamann May 8, 2020 11:37
fastly/loggly.go Outdated
CreatedAt *time.Time `mapstructure:"created_at"`
UpdatedAt *time.Time `mapstructure:"updated_at"`
DeletedAt *time.Time `mapstructure:"deleted_at"`
Placement string `mapstructure:"placement"`
Copy link
Contributor

@mccurdyc mccurdyc May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, let's put *At at the bottom.

(I've fixed).

Copy link
Contributor

@mccurdyc mccurdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mccurdyc mccurdyc merged commit 8e17304 into fastly:master May 11, 2020
@ezkl ezkl deleted the ezkl/add-loggly branch May 19, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants