feat(profile/token): Allow user to specify how long token must be valid. #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default token validity period for 'fastly profile token' is 5 minutes, but users may want to ensure that the token is valid for a longer period (or only a shorter period). This PR adds 'fastly profile token --ttl=<period>', allowing the user to specify the validity period in seconds, minutes, or hours (or some combination).
Profiles with non-OIDC tokens (tokens generated using the traditional Fastly token-creation methods) do not contain expiration information, so the validity-checking in the `fastly profile token` command should not attempt to validate them.
The `fastly profile update` command is not the best suggestion in this situation; the user should directly invoke `fastly sso` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default token validity period for 'fastly profile token' is 5 minutes, but users may want to ensure that the token is valid for a longer period (or only a shorter period). This PR adds 'fastly profile token --ttl=<period>', allowing the user to specify the validity period in seconds, minutes, or hours (or some combination).