Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the run method to get the json_report value #154

Merged
merged 3 commits into from
Apr 26, 2020
Merged

Updated the run method to get the json_report value #154

merged 3 commits into from
Apr 26, 2020

Conversation

lonnyantunes
Copy link
Contributor

To get the json_report value in order to take into account the changes in the following pr :
fastlane-community/danger-xcov#28

Update of the xcov gem version number related to the method to get the json_report value
…nto update_run_method

# Conflicts:
#	lib/xcov/version.rb
@lonnyantunes
Copy link
Contributor Author

Hello @joshdholtz @Zeta611,

with my team, we would like to use xcov and the danger-xcov plugin.
We need you to merge 2 PR please:

Can you help us ?
Thank you

@joshdholtz
Copy link
Member

Hello! I will take a look at those today! Thanks for the ping ❤️

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight forward enough to me 😇 Thanks for the contribution! ❤️

@joshdholtz joshdholtz merged commit 2cd5937 into fastlane-community:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants