Fixed issue with wrong average coverage when ignored files exist. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the fix. This was a real problem with existing xcov version I am facing. Please prioritize to merge this pull request ASAP |
|
@joshdholtz please approve this PR. |
|
Is there a way to test this fix? I would like to test it before merging to master |
|
@chinnasamymca I could reproduce this by adding some targets as ignored. The resulting sum is not correct and seems to take care of the ignored target/files. |
|
Any update on this? |
|
Closing in favor of #170 which reverted the original commit that broke this. I appreciate the contribution ❤️ And sorry about not seeing this PR 😔 The new GitHub app and revamp of notifications has helped me see pings better so I will aim to improve in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that when you have many ignored files the target coverage is altered.
This fix seems to fix the bug.