Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move /organisations to /organizations #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

10xLaCroixDrinker
Copy link
Contributor

Description

This PR moves the /organisations route to /organizations and adds a redirect from the old route to the new.

Related Issues

Related to discussion in fastify/fastify#5349

Check List

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Can we add a redirect somehow? cc @jsumners

@10xLaCroixDrinker
Copy link
Contributor Author

Do you mean a server side redirect?

There's a client side redirect added in the docusaurus config at lines 208-213

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsumners
Copy link
Member

lgtm

Can we add a redirect somehow? cc @jsumners

Yes, we can add a page rule in Cloudflare for this (though it will use up one of our three available).

@Eomm
Copy link
Member

Eomm commented Apr 10, 2024

We handle redirects here:

function manageRedirects({ existingPath, major, versions, versionsShipped, ignore = [] }) {

but: https://prowritingaid.com/organisation-vs-organization

and the previous website stands with organisations:
https://github.com/fastify/website-metalsmith/blob/master/src/website/content/organisations.md

@Eomm
Copy link
Member

Eomm commented Apr 25, 2024

Could you update the PR? we fixed the deploy to staging.

Plus: why we don't add a redirect from organizations to organisations instead?
this would ease the job

@gurgunday
Copy link
Member

It was because the website uses American English everywhere else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants