-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last update time at /benchmarks page #198
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gurgunday pipeline seems to fail on staging https://github.com/fastify/website/actions/runs/8246279348/job/22552358761?pr=198 |
@gurgunday do you have a chance to look into this? The error in the CD pipeline doesn't seem to be related to the changes in this PR |
@Eomm is more familiar than me and might be able to help faster, but I’ll try to take a look |
I tried to fix but failed, but I think there is something broken with GHA and netlify |
could you update the PR with the main branch? We fixed the deploy on staging |
3de85d2
to
8633c45
Compare
@marcoturi could you please merge |
Description
Add the date info of used benchmark commit inside benchmarks.json. Then use the date in the /benchmarks page
Related Issues
Addresses #176
Check List