Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last update time at /benchmarks page #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcoturi
Copy link

@marcoturi marcoturi commented Mar 11, 2024

Description

Add the date info of used benchmark commit inside benchmarks.json. Then use the date in the /benchmarks page

Related Issues

Addresses #176

Check List

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcoturi
Copy link
Author

marcoturi commented Mar 12, 2024

@gurgunday pipeline seems to fail on staging https://github.com/fastify/website/actions/runs/8246279348/job/22552358761?pr=198
let me know if you need anything from my side :)

@simoneb
Copy link

simoneb commented Mar 28, 2024

@gurgunday do you have a chance to look into this? The error in the CD pipeline doesn't seem to be related to the changes in this PR

@gurgunday
Copy link
Member

@Eomm is more familiar than me and might be able to help faster, but I’ll try to take a look

@Eomm
Copy link
Member

Eomm commented Apr 10, 2024

@Eomm is more familiar than me and might be able to help faster, but I’ll try to take a look

I tried to fix but failed, but I think there is something broken with GHA and netlify

@Eomm Eomm changed the title Add last update time at /benchmarks page, close #176 Add last update time at /benchmarks page Apr 25, 2024
@Eomm Eomm linked an issue Apr 25, 2024 that may be closed by this pull request
@Eomm
Copy link
Member

Eomm commented Apr 25, 2024

could you update the PR with the main branch?

We fixed the deploy on staging

@Eomm
Copy link
Member

Eomm commented Nov 30, 2024

@marcoturi could you please merge main into this branch so we can land this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

last update time at /benchmarks page
5 participants