-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate test suite from tap to node:test #76
Conversation
e913a6b
to
6e75e21
Compare
Do we need c8 or can we use the built-in coverage? https://nodejs.org/api/test.html#collecting-code-coverage |
@simoneb Thanks for suggesting the use of Node.js's built-in coverage. After consideration, I think we should stick with c8 for now. Here's why:
However, I agree it's a good idea to eventually move to the built-in coverage. I suggest we:
This way, we maintain stability for our users while staying prepared to adopt the built-in solution when it's ready. What do you think? |
Sounds good, I brought it up in case other maintainers have an opinion on this |
Use c8 for now. |
test.js
Outdated
t.plan(1) | ||
t.strictSame(typeof Hook, 'function') | ||
test('pre-commit', async (t) => { | ||
await t.test('is exported as a function', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change to use the built-in t.plan
and t.assert
?
3c5eb5c
to
1658fd3
Compare
This PR replaces tap with node:test and introduces c8 for code coverage.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct