chore: update fastify to ^5.0.0 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fdawgs can you take a look why this is failing? Also we can disable package-manager-ci or figure out why it is failing? |
types/index.test-d.ts:21:0
✖ 21:0 Parameter type (opts?: PrettyOptions | undefined) => PrettyStream is declared too wide for argument type typeof PinoPretty.
1 error |
|
Thanks @gurgunday, I find spotting errors in Tap output a nightmare! |
|
@fastify/typescript @fastify/plugins
|
|
please remove package manager CI |
Done. As @gurgunday raised in a comment before, CI is failing due to a TypeScript type issue, but my TypeScript knowledge is amateur at best so no idea how to solve it. |
This comment was marked as outdated.
This comment was marked as outdated.
|
In all honesty the I'm not entirely confident about the fix I did for the tsd failure, as my TS knowledge is fairly limited as well. I can't really bother with TS idiosincrasies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fastify/fastify#5694
Checklist
npm run testandnpm run benchmarkand the Code of conduct