Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress warning in ci/cd pipeline, add lint:fix script #520

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 11, 2023

Removes the first warning, which is part of the unit tests

image

Checklist

@Uzlopak Uzlopak requested a review from simoneb October 11, 2023 11:30
@Uzlopak Uzlopak linked an issue Oct 11, 2023 that may be closed by this pull request
2 tasks
@Uzlopak Uzlopak changed the title fix: suppress warning in ci/cd pipeline fix: suppress warning in ci/cd pipeline, add lint:fix script Oct 11, 2023
Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look to be doing what it intends to do, as there is only a test file changed

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 11, 2023

@simoneb

See now in comparison to the screenshot.
https://github.com/fastify/github-action-merge-dependabot/actions/runs/6481932538

image

In test/util.test.js we dont stub logWarning. So we actually use the console of @actions/core and emitting the test warning into the ci/cd pipeline of this repository.
This PR stubs logWarning, so we dont emit this irritating warning. ;)

@simoneb
Copy link
Collaborator

simoneb commented Oct 11, 2023

ah I see, it was a warning in the test

@Uzlopak Uzlopak merged commit 464500f into main Oct 11, 2023
5 checks passed
@Uzlopak Uzlopak deleted the suppress-warning branch October 11, 2023 13:34
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress warning in CI/CD pipeline
2 participants