Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for named export in Node v14.13.0 #2590

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Support for named export in Node v14.13.0 #2590

merged 1 commit into from
Sep 30, 2020

Conversation

mcollina
Copy link
Member

Checklist

fox1t
fox1t approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fox1t
Copy link
Member

fox1t commented Sep 30, 2020

This is huge for the interoperability! I was hoping for this feature to be added to Node.js for months now and I've completely missed the related PR.
🎉

@fox1t
Copy link
Member

fox1t commented Sep 30, 2020

Note: we need to change this "infamous triplet" export all over the place. :)

RafaelGSS
RafaelGSS approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

zekth
zekth approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

delvedor
delvedor approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added v3.x Issue or pr related to Fastify v3 semver-minor Issue or PR that should land as semver minor labels Sep 30, 2020
Ethan-Arrowood
Ethan-Arrowood approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🍻

@mcollina mcollina merged commit ba03e10 into master Sep 30, 2020
@mcollina mcollina deleted the named-exports branch September 30, 2020 13:19
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kibertoad kibertoad kibertoad left review comments

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@zekth zekth zekth approved these changes

@delvedor delvedor delvedor approved these changes

@fox1t fox1t fox1t approved these changes

Assignees
No one assigned
Labels
semver-minor Issue or PR that should land as semver minor v3.x Issue or pr related to Fastify v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mcollina @fox1t @kibertoad @delvedor @zekth @Ethan-Arrowood @RafaelGSS