Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master in next #1954

Merged
merged 142 commits into from
Dec 24, 2019
Merged

Merge master in next #1954

merged 142 commits into from
Dec 24, 2019

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Nov 24, 2019

Replace #1953

Typescript output:

  ×  11:2   Expected an error, but found none.

  ×  11:51  No overload matches this call.
  Overload 1 of 2, (msg: string, ...args: any[]): void, gave the following error.
    Argument of type 0 is not assignable to parameter of type string.
  Overload 2 of 2, (obj: object, msg?: string | undefined, ...args: any[]): void, gave the following error.
    Argument of type 0 is not assignable to parameter of type object.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

smartiniOnGitHub and others added 30 commits May 13, 2019 22:33
@smartiniOnGitHub @Eomm
add tap into greenkeeper ignore list (fastify#1643)
d6b5354
@L2jLiga @mcollina
Added fastify-decorators to Ecosystem.md (fastify#1645)
5a01a55
@rand0me @delvedor
Fix typo in azure-pipelines.yml (fastify#1649)
0ce4f0d 
Windows + Yarn section name was `Windows_yarm`
@Eomm
offboarding steps (fastify#1646)
a210899
@SkeLLLa @Eomm
fix(types): fix register options (fastify#1644)
f627bbf
@Eomm
chore(package): update flatstr to version 1.0.12 (fastify#1653)
6e4e662
@fox1t @delvedor
Catches onRoute hooks errors (fastify#1651)
481d809 
* Catches onRoute hooks errors

* Fixes typo

* Removes unneeded test
@Eomm
add example repo link (fastify#1648)
d1dab14
@greenkeeper @mcollina
chore(package): update send to version 0.17.0 (fastify#1627)
dd05901
@mcollina
Emit warning synchronously (fastify#1657)
1f3c0de 
Fixes fastify#1656
@arswaw @Eomm
Make some spelling and grammar corrections to TS.md (fastify#1640)
d377ebe
@Eomm
internal: moved route code (fastify#1625)
9e65ca4
@mokimo @Eomm
docs(reply): clarify settings headers (fastify#1642)
ff5bfdd
@mcollina
Bumped v2.4.0
a6fa039
@dalisoft @Eomm @delvedor
Add .git folder to NPM ignore (fastify#1663)
5d442c5 
* Add .git folder to NPM ignore

* Update .npmignore

Co-Authored-By: Manuel Spigolon <[email protected]>
@delvedor
Bumped v2.4.1
712337d
@fox1t @delvedor
Adds defaults to TS generics definitions (fastify#1669)
1958c74
@Ethan-Arrowood @mcollina
Update node types, typescript, and fix broken test (fastify#1681)
7f274d1
@SkeLLLa @Eomm
Add RBAC plugin to Ecosystem (fastify#1692)
fc52dc3
@fox1t @delvedor
Removes double call to afterRouteAdded when ignoreTrailingSlash === t…
ecea232 
…rue (fastify#1675)

* Removes double call to afterRouteAdded when ignoreTrailingSlash === true

* Adds explaining comment when adding a prefixed plugin
@RafaelGSS @Eomm
docs: fix req.body inside logger req (fastify#1695)
41a94c3
@raghavmac @Eomm
Alias schema.query to schema.querystring (fastify#1690) (fastify#1694)
bdc137e
@xtx1130 @mcollina
docs: fix typos (fastify#1701)
00d0e23
@Eomm
chore: greenkeeper ignore autocannon (fastify#1696)
b53f037
@XVincentX @delvedor
fix: use reply instead of original res (fastify#1704)
d8730a2
@hhwang39 @delvedor
Added case sensitive option to definition file. (fastify#1691)
fda8448 
* Added case sensitive option to definition file.

* Added casSensitive Option to test
@GlenTiki @delvedor
add ability to get response time on reply (fastify#1697)
1ad7566 
* add ability to get response time on reply

* feedback

* Update docs/Reply.md as per suggestion

Co-Authored-By: Manuel Spigolon <[email protected]>

* update type of FastifyReply

* add type test
@delvedor
Bumped v2.5.0
901911c
@Eomm
feature: custom serializator (fastify#1706)
78c867f
@delvedor
Improve support for Fluent Schema (fastify#1719)
02f4807 
* Improve support for Fluent Schema

* Updated test

* Updated docs

* Avoid code duplication
@Eomm Eomm added the v3.x Issue or pr related to Fastify v3 label Nov 24, 2019
@Eomm Eomm mentioned this pull request Nov 24, 2019
Closed
4 tasks
@Eomm
Copy link
Member Author

Eomm commented Nov 25, 2019

It is ok for the merge 💪🏻, I will update this pr accordingly because it is on a fork (unless you would open a PR there ✨)

@Ethan-Arrowood
Copy link
Member

Ethan-Arrowood commented Nov 25, 2019 •
edited
Loading

Something is missing here and I don't fully understand. #1951 fixed all the typescript things so if there is a way to get that to show here it should be good to go

Ethan-Arrowood
Ethan-Arrowood suggested changes Nov 25, 2019
View reviewed changes
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to update the ci script and we'll be good to go

package.json Outdated Show resolved Hide resolved
@delvedor delvedor mentioned this pull request Dec 9, 2019
Closed
4 tasks
delvedor
delvedor reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status on this? :)

@Eomm
Copy link
Member Author

Eomm commented Dec 12, 2019

mmm CI is failing in install phase.. seems a resource problem 😅

@theliuk theliuk mentioned this pull request Dec 16, 2019
Closed
4 tasks
@Eomm
Copy link
Member Author

Eomm commented Dec 23, 2019

CI green ✔

@Ethan-Arrowood would you mind to re-check if necessary?
I have included your edits 👍

Ethan-Arrowood
Ethan-Arrowood approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delvedor
delvedor approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit f47b3d2 into fastify:next Dec 24, 2019
@Eomm Eomm deleted the next-up branch December 24, 2019 20:26
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
v3.x Issue or pr related to Fastify v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.