Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): replace standard with neostandard #116

Merged
merged 2 commits into from
Dec 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[![CI](https://github.com/fastify/fastify-zipkin/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/fastify/fastify-zipkin/actions/workflows/ci.yml)
[![NPM version](https://img.shields.io/npm/v/@fastify/zipkin.svg?style=flat)](https://www.npmjs.com/package/@fastify/zipkin)
[![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg?style=flat)](https://standardjs.com/)
[![neostandard javascript style](https://img.shields.io/badge/code_style-neostandard-brightgreen?style=flat)](https://github.com/neostandard/neostandard)

Fastify plugin for [Zipkin](https://zipkin.io/) distributed tracing system.

Expand Down
6 changes: 6 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
'use strict'

module.exports = require('neostandard')({
ignores: require('neostandard').resolveIgnoresFromGitignore(),
ts: true
})
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@
"type": "commonjs",
"types": "types/index.d.ts",
"scripts": {
"zipkin": "docker run -p 9411:9411 openzipkin/zipkin",
"lint": "standard",
"lint": "eslint",
"lint:fix": "eslint --fix",
"test": "npm run test:unit && npm run test:typescript",
"test:unit": "c8 --100 node --test",
"test:typescript": "tsd"
"test:typescript": "tsd",
"zipkin": "docker run -p 9411:9411 openzipkin/zipkin"
},
"repository": {
"type": "git",
Expand All @@ -30,9 +31,9 @@
"@fastify/pre-commit": "2.2.0",
"c8": "^10.1.2",
"fastify": "^5.0.0",
"neostandard": "^0.11.9",
"node-fetch": "^2.6.7",
"sinon": "^19.0.2",
"standard": "^17.0.0",
"tsd": "^0.31.0"
},
"dependencies": {
Expand Down
8 changes: 4 additions & 4 deletions types/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { FastifyPluginCallback } from 'fastify';
import { Recorder, Tracer } from 'zipkin';
import { FastifyPluginCallback } from 'fastify'
import { Recorder, Tracer } from 'zipkin'

type FastifyZipkin = FastifyPluginCallback<fastifyZipkin.FastifyZipkinOptions>;
type FastifyZipkin = FastifyPluginCallback<fastifyZipkin.FastifyZipkinOptions>

declare namespace fastifyZipkin {
export interface FastifyZipkinOptions {
Expand All @@ -17,5 +17,5 @@ declare namespace fastifyZipkin {

}

declare function fastifyZipkin(...params: Parameters<FastifyZipkin>): ReturnType<FastifyZipkin>
declare function fastifyZipkin (...params: Parameters<FastifyZipkin>): ReturnType<FastifyZipkin>
export = fastifyZipkin
4 changes: 3 additions & 1 deletion types/index.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ fastify.register(zipkinPlugin, { serviceName: 'test', httpReporterUrl: 'http://'
fastify.register(zipkinPlugin, { serviceName: 'test', httpReporterUrl: 'http://', servicePort: 0 })
fastify.register(zipkinPlugin, { serviceName: 'test', httpReporterUrl: 'http://', recorder: new ConsoleRecorder() })
fastify.register(zipkinPlugin, {
serviceName: 'test', httpReporterUrl: 'http://', tracer: new Tracer({
serviceName: 'test',
httpReporterUrl: 'http://',
tracer: new Tracer({
ctxImpl: new ExplicitContext(),
recorder: new ConsoleRecorder()
})
Expand Down
Loading