Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fastify 5 with separated type-providers #97

Closed
wants to merge 2 commits into from

Conversation

Bram-dc
Copy link
Contributor

@Bram-dc Bram-dc commented Jun 12, 2024

Checklist

The tests will not work since this fastify 5 change has not been committed yet.

This is a patch to work correctly with fastify/fastify#5427

@Bram-dc
Copy link
Contributor Author

Bram-dc commented Jun 12, 2024

Do we need to add a message in the README that this only works for fastify >=5 ?

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you target next please?

@gurgunday
Copy link
Member

gurgunday commented Jun 12, 2024

Do we need to add a message in the README that this only works for fastify >=5 ?

Targeting next is enough

package.json Outdated Show resolved Hide resolved
@gurgunday gurgunday changed the base branch from main to next June 12, 2024 11:09
@gurgunday
Copy link
Member

@gurgunday
Copy link
Member

Please pull from the next branch

@Bram-dc
Copy link
Contributor Author

Bram-dc commented Jun 16, 2024

Please pull from the next branch

Do you mean the github branch "next" instead of the npm tag "next"? Is there a difference?

package.json Outdated Show resolved Hide resolved
Signed-off-by: Gürgün Dayıoğlu <[email protected]>
@gurgunday
Copy link
Member

Do you know why it’s failing? Maybe we need to release a more recent v5

@Bram-dc
Copy link
Contributor Author

Bram-dc commented Jun 20, 2024

Fastify 5 with these changes has not been published to npm. The "next" tag references "5.0.0-aplha.1", which does not have these changes.

@jsumners jsumners mentioned this pull request Jun 29, 2024
@jsumners
Copy link
Member

jsumners commented Jul 2, 2024

Resolved by #100.

@jsumners jsumners closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants