-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fastify 5 with separated type-providers #97
Conversation
Do we need to add a message in the README that this only works for fastify >=5 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you target next please?
Targeting next is enough |
Please pull from the next branch |
Do you mean the github branch "next" instead of the npm tag "next"? Is there a difference? |
Signed-off-by: Gürgün Dayıoğlu <[email protected]>
Do you know why it’s failing? Maybe we need to release a more recent v5 |
Fastify 5 with these changes has not been published to npm. The "next" tag references "5.0.0-aplha.1", which does not have these changes. |
Resolved by #100. |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct
The tests will not work since this fastify 5 change has not been committed yet.
This is a patch to work correctly with fastify/fastify#5427