-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds endpoint-specific transforms #752
Conversation
Two considerations for the reviewer:
|
7ea0a17
to
bde7dbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing typing tests.
Added some tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed it now.
swggerTransform null is quiet unintuitive. I would personally prefer false for deactivating.
Use "false" instead of "null" to disable the global schema transform.
I agree, changed it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When is this set to be released? 🤔 |
done now |
Addressing #749
Checklist
npm run test
andnpm run benchmark
and the Code of conduct