Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use JSONObject for transform. #726

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Don't use JSONObject for transform. #726

merged 1 commit into from
Jun 15, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Jun 4, 2023

Checklist

I'll use CI to make sure npm run test and npm run benchmark are AOK. I can elaborate on why this change is necessary, but instead just look at the changes to the tests. BTW the example in the readme still works (once you change it by making transformedSchema be ...ts then const transformedSchema = ts as FastifySchema).

@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 14, 2023

Hi! Maybe the Windows flakiness is gone now?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3618eb0 into fastify:master Jun 15, 2023
@mcollina
Copy link
Member

This can land! thx

@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 15, 2023

Thank you!

@A5rocks A5rocks deleted the no-json-object branch June 15, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants