Clone schemas

lib/spec/openapi/utils.js

@@ -82,7 +82,7 @@ function transformDefsToComponents (jsonSchema) {
   if (typeof jsonSchema === 'object' && jsonSchema !== null) {
     // Handle patternProperties, that is not part of OpenAPI definitions
     if (jsonSchema.patternProperties) {
-      jsonSchema.additionalProperties = Object.values(jsonSchema.patternProperties)[0];
+      jsonSchema.additionalProperties = Object.values(jsonSchema.patternProperties)[0]
       delete jsonSchema.patternProperties
     } else if (jsonSchema.const) {
       // OAS 3.1 supports `const` but it is not supported by `swagger-ui`

lib/util/common.js

@@ -3,6 +3,7 @@
 const fs = require('fs')
 const path = require('path')
 const Ref = require('json-schema-resolver')
+const cloner = require('rfdc')({ proto: true, circles: false })
 const { rawRequired } = require('../symbols')
 const { xConsume } = require('../constants')
 
@@ -21,7 +22,7 @@ function addHook (fastify, pluginOptions) {
     // when schemaId is the same in difference instance
     // the latter will lost
     instance.addHook('onReady', (done) => {
-      const allSchemas = instance.getSchemas()
+      const allSchemas = cloner(instance.getSchemas())
       for (const schemaId of Object.keys(allSchemas)) {
         if (!sharedSchemasMap.has(schemaId)) {
           sharedSchemasMap.set(schemaId, allSchemas[schemaId])

package.json

@@ -62,7 +62,8 @@
     "fastify-static": "^4.0.0",
     "js-yaml": "^4.0.0",
     "json-schema-resolver": "^1.3.0",
-    "openapi-types": "^10.0.0"
+    "openapi-types": "^10.0.0",
+    "rfdc": "^1.3.0"
   },
   "standard": {
     "ignore": [

test/spec/openapi/refs.js

@@ -135,6 +135,36 @@ test('support $ref in response schema', async (t) => {
   await Swagger.validate(openapiObject)
 })
 
+test('support $ref for enums in other schemas', async (t) => {
+  const fastify = Fastify()
+
+  const enumSchema = { $id: 'order', anyOf: [{ type: 'string', const: 'foo' }, { type: 'string', const: 'bar' }] }
+  const enumRef = { $ref: 'order' }
+  const objectWithEnumSchema = { $id: 'object', type: 'object', properties: { type: enumRef }, required: ['type'] }
+
+  await fastify.register(fastifySwagger, openapiOption)
+  await fastify.register(async (instance) => {
+    instance.addSchema(enumSchema)
+    instance.addSchema(objectWithEnumSchema)
+    instance.post('/', { schema: { body: { type: 'object', properties: { order: { $ref: 'order' } } } } }, async () => ({ result: 'OK' }))
+  })
+
+  await fastify.ready()
+
+  const responseBeforeSwagger = await fastify.inject({ method: 'POST', url: '/', payload: { order: 'foo' } })
+
+  t.equal(responseBeforeSwagger.statusCode, 200)
+  const openapiObject = fastify.swagger()
+
+  t.equal(typeof openapiObject, 'object')
+
+  await Swagger.validate(openapiObject)
+
+  const responseAfterSwagger = await fastify.inject({ method: 'POST', url: '/', payload: { order: 'foo' } })
+
+  t.equal(responseAfterSwagger.statusCode, 200)
+})
+
 test('support nested $ref schema : complex case without modifying buildLocalReference', async (t) => {
   const fastify = Fastify()
   fastify.register(fastifySwagger, { openapi: {} })