Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme and CI #348

Merged
merged 8 commits into from
Feb 2, 2021
Merged

Update readme and CI #348

merged 8 commits into from
Feb 2, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Feb 2, 2021 •
edited
Loading

Main purpose of this pull request is to update the readme to remove mention of OpenAPI v3.*.* being unsupported, as #333 adds this functionality.

Ended up getting carried away and adding a few extra badges and coveralls coverage generation into the CI as well. 😄

Checklist

zekth
zekth approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. good initiative (coveralls config need to be adjusted to pass the CI)

mcollina
mcollina approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9f92400 into fastify:master Feb 2, 2021
@Fdawgs Fdawgs deleted the docs/updates branch February 2, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekth zekth zekth approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fdawgs @mcollina @zekth