Fix type of StaticDocumentSpec.document in index.d.ts #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fox1t
reviewed
Dec 9, 2020
radzom
force-pushed
the
fix-document-type
branch
from
51b273a to
38bd561
Compare
radzom
commented
Dec 15, 2020
mcollina
requested changes
Dec 15, 2020
radzom
force-pushed
the
fix-document-type
branch
from
38bd561 to
1e9f8e6
Compare
radzom
force-pushed
the
fix-document-type
branch
from
1e9f8e6 to
40e7f99
Compare
fox1t
approved these changes
Dec 15, 2020
Ethan-Arrowood
approved these changes
Dec 15, 2020
|
Hi, is there anything left I need, can or have to do for this pull request? |
|
@radzom nothing else on your end I believe. We do our merges and releases manually so whenever that happens for this plugin your work will be completed and released. Thank you for contributing 😄 |
8 tasks
|
Landed :) |
mcollina
pushed a commit
that referenced
this pull request
Jan 26, 2021
* refactor: better file structure - reduce the number of files in root folder * refactor: extract common function - hook - formatParamUrl - consumesFormOnly - plainJsonObjectToSwagger2 - localRefResolve * refactor: split dynamic handle to swagger and openapi * feat: add openapi 3 support * test: add openapi 3 test case * feat: update openapi from 3.0.0 to 3.0.3 * refactor: typo - properyName to propertyName * refactor: more clear argument - h to headers * refactor: use map instead of reduce * refactor: use done instead of next * refactor: group functions - remove getQueryParams, getPathParams, getHeaderParams, getFormParams - add getParams * refactor: genResponse to generateResponse * chore: remove invalid comment * refactor: better structure - split util to dynamicUtil, OpenapiUtil, swaggerUtil - extract inline function from openapi and swagger * feat: generate response according to produces * feat: use package json as default info * refactor: better cache name * chore: add comment to address different issue * feat: add oneOf, allOf, anyOf support in query, header, path, formData * Fix type of StaticDocumentSpec.document (#328) * refactor: better file structure - reduce the number of files in root folder * refactor: extract common function - hook - formatParamUrl - consumesFormOnly - plainJsonObjectToSwagger2 - localRefResolve * refactor: split dynamic handle to swagger and openapi * feat: add openapi 3 support * test: add openapi 3 test case * feat: update openapi from 3.0.0 to 3.0.3 * refactor: typo - properyName to propertyName * refactor: more clear argument - h to headers * refactor: use map instead of reduce * refactor: use done instead of next * refactor: group functions - remove getQueryParams, getPathParams, getHeaderParams, getFormParams - add getParams * refactor: genResponse to generateResponse * chore: remove invalid comment * refactor: better structure - split util to dynamicUtil, OpenapiUtil, swaggerUtil - extract inline function from openapi and swagger * feat: generate response according to produces * feat: use package json as default info * refactor: better cache name * chore: add comment to address different issue * feat: add oneOf, allOf, anyOf support in query, header, path, formData * refactor: better argument name * feat: add cookies schema support for openapi 3 * fix: typo * chore: add openapi typings * docs: add openapi support docs * docs: update as suggestion * fix: openapi Co-authored-by: radzom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #327
The type of the property 'document' in the interface StaticDocumentSpec in the file 'index.d.ts' was formerly specified as 'string' and was corrected to object.
I think one could even specify it as one of
Are there other versions that would then need to be supported?
Checklist
npm run testandnpm run benchmarkand the Code of conduct