Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fastify to v3 #238

Merged
merged 7 commits into from
May 16, 2020
Merged

Update fastify to v3 #238

merged 7 commits into from
May 16, 2020

Conversation

frikille
Copy link
Contributor

@frikille frikille commented May 5, 2020

  • Updates fastify to v3
  • Adds dependabot config
  • Moves CI from Travis to Github Actions

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

mcollina
mcollina requested changes May 5, 2020
View reviewed changes
.dependabot/config.yml Outdated Show resolved Hide resolved
@mcollina mcollina requested a review from Eomm May 5, 2020 13:08
@mcollina
Copy link
Member

mcollina commented May 5, 2020

@Eomm can you take a look?

Eomm
Eomm requested changes May 6, 2020
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the new api interface

test/transform.js Outdated Show resolved Hide resolved
test/transform.js Outdated Show resolved Hide resolved
@Eomm Eomm mentioned this pull request May 6, 2020
Merged
frikille and others added 2 commits May 7, 2020 09:06
@frikille @Eomm
Update test/transform.js
37df011 
Co-authored-by: Manuel Spigolon <[email protected]>
@frikille @Eomm
Update test/transform.js
083bc0c 
Co-authored-by: Manuel Spigolon <[email protected]>
Eomm
Eomm approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NOTE to fastify team: I would no release this PR until complete $ref support ( #239 )

@Eomm Eomm requested a review from mcollina May 9, 2020 16:06
@Eomm
Copy link
Member

Eomm commented May 16, 2020

@mcollina I need this merge to complete #239

mcollina
mcollina approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 433fd05 into fastify:master May 16, 2020
@mcollina
Copy link
Member

landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frikille @mcollina @Eomm