Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on lib.dom.d.ts #204

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

smartinio
Copy link
Contributor

Fixes #142

Checklist

Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it even possible to define HTMLElement in domNode? I guess we could remove that option anyway.

@smartinio
Copy link
Contributor Author

@Uzlopak I don't think there is, but seemed safer to not make a breaking change. Can remove the option altogether if that's preferred though.

@smartinio smartinio requested a review from Uzlopak January 29, 2025 10:18
@smartinio smartinio requested a review from Uzlopak January 29, 2025 12:15
Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

types/index.d.ts Show resolved Hide resolved
@Uzlopak Uzlopak merged commit 91cb210 into fastify:master Jan 30, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This library should not depend DOM types
2 participants