Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add indexPrefix option #189

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

rozzilla
Copy link
Contributor

@rozzilla rozzilla commented Dec 3, 2024

I can't push to the branch associated with this PR.

So I created a new branch that cherry-pick the commit 3d7c3121ce7550de828d6caa8525f8c7e846eb4b, and adds tsd typescript tests.

@rozzilla rozzilla changed the title Feat/add index prefix option feat/add index prefix option Dec 3, 2024
@rozzilla rozzilla changed the title feat/add index prefix option feat: Add indexPrefix option Dec 3, 2024
@rozzilla rozzilla changed the title feat: Add indexPrefix option feat: Add indexPrefix option Dec 3, 2024
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rozzilla can you fix failing tests

Signed-off-by: Roberto Bianchi <[email protected]>
@rozzilla rozzilla requested a review from dancastillo December 3, 2024 14:17
@rozzilla rozzilla mentioned this pull request Dec 3, 2024
4 tasks
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ff68299 into fastify:master Dec 3, 2024
16 checks passed
@Fdawgs
Copy link
Member

Fdawgs commented Dec 17, 2024

Thanks for this @rozzilla, just happened to need this myself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants